hbenl / vscode-test-explorer

The VS Code Test Explorer extension
MIT License
215 stars 55 forks source link

Visibility of icons when the test is highlighted/selected #90

Open vladimir-djokic opened 5 years ago

vladimir-djokic commented 5 years ago

This is a nitpick from me, but when using Light+ theme in VSCode, visibility of icons for selected test is not good, as in screenshot:

Annotation 2019-08-12 143428

If they would become white (as does the text), then they would be much easier to view.

hacknug commented 5 years ago

I'd say they should use the same dark grey those icons on the right. UI-wise that's what the whole app does.

hbenl commented 5 years ago

It would be nice if the icons could change color like the text does. Unfortunately, I don't see how I could do this, the API doesn't allow me to specify different icons for the selected element. Looking at other extensions and even built-in icons in the VS Code UI, they all remain dark even when the background becomes dark because the element was selected.

vladimir-djokic commented 5 years ago

@hbenl I do not believe that this should have been closed so eagerly. This issue can be resolved, as demonstrated in the screenshot:

Annotation 2019-09-02 174001

What you can observe in the screenshot is the white outline present for he light theme.

Here is the screenshot when using dark theme:

Annotation 2019-09-02 174207

Also note that some of square-in-circle icon (icon in front of the specs) is not the color used by the rest of the icons (as mentioned by @hacknug) so it looks "pale" in both light and dark themes.

hbenl commented 5 years ago

@vladeck Thanks, the white outline is an excellent solution (as your screenshots show).

numaru commented 5 years ago

The vscode team is working on a way to dynamically set the color of the icons and it is in the iteration plan for september. microsoft/vscode#78889 is marked related to microsoft/vscode#55857. Also, there is a good chance to see a new api in the next version of vscode to use theme-able icons.