search

hbf / miniball

Fast computation of the smallest enclosing ball of a point set, in low or moderately high dimensions.
133 stars 41 forks source link

Python extension #32

Closed adamheins closed 2 years ago

adamheins commented 2 years ago

This is a proposal for changing the Python bindings such that they're written as a C++ extension, one benefit of which is that it can be installed in the usual way with python setup.py install (and thus can be readily included in other projects without copying code). I've matched the API from the original implementation, and the tests are the same except for the type of exception raised for passing the wrong argument.

Let me know if you think this would be a useful change. I'm happy to make any changes to this code, and if we decide to go forward with this PR I can clean up the commit history before merging.

hbf commented 2 years ago

I'm happy to make any changes to this code, and if we decide to go forward with this PR I can clean up the commit history before merging.

FYI I switched the project settings to only offer “Squash and merge”.

hbf commented 2 years ago

Thanks again. Happy to add you also to the README if you’d like that, feel free to make a PR.