search

hbf / miniball

Fast computation of the smallest enclosing ball of a point set, in low or moderately high dimensions.
133 stars 41 forks source link

Python: ndarray type checking #35

Closed rasmushaugaard closed 1 year ago

rasmushaugaard commented 1 year ago

Hi there and thank you for your work!

The python binding assumes a contiguous double numpy array, but it does not check for it, and passing a non-contiguous array or an array of another type fails silently. I've added type checking with error messages and automatic conversion to contiguous arrays.

Also, on my setup (ubuntu22, anaconda) the setup failed to locate numpy include dirs. I've updated setup.py appropriately.

Let me know if something needs to be changed.

rasmushaugaard commented 1 year ago

@hbf do you need more from me towards getting this merged?

hbf commented 1 year ago

@hbf do you need more from me towards getting this merged?

Nope. I assumed you had merge permission but looks like you didn't. I added you as a collaborator to the project so now you should be able to merge. Lmk if not!