search

hbi99 / defiant.js

http://defiantjs.com
GNU Affero General Public License v3.0
913 stars 91 forks source link

Fix for IE11 #87

Closed HughxDev closed 7 years ago

HughxDev commented 7 years ago

Addresses #16 (for real this time).

hbi99 commented 7 years ago

@hguiney, Super...I'd merge this but can I suggest that you bump the version in "package.json"? When done, use "gulp minify" to create dist versions of the lib.

If you dont want to do that, please omit the version number in "dist/defiant.js" and I'll do the version bump myself.

Cheers

yanndebelgique commented 7 years ago

waiting for this merge...

hbi99 commented 7 years ago

I'll clean up and add this code from this pull-request. But it will not be a merge since there are merge-conflicts.

HughxDev commented 7 years ago

Sorry for the radio silence. I’ll bump the version number and minify to make it a proper merge.

HughxDev commented 7 years ago

OK, fixed!

yanndebelgique commented 7 years ago

Thx!!

Apologies for brevity and typos. Sent from my iPhone

On 10 Oct 2017, at 19:51, Hugh Guiney notifications@github.com wrote:

OK, fixed!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

hbi99 commented 7 years ago

Cool...merging. @hguiney - can you verify that it all works as you expect?

Thanks in advance