search

hbldh / pybankid

BankID Relying Party client for Python
https://pybankid.readthedocs.io
MIT License
48 stars 19 forks source link

Bugfix: User Non visible data was not used. #14

Closed sheepsy90 closed 6 years ago

sheepsy90 commented 6 years ago

When checking the XML that was the signature I was seeing the user visible data in both xml fields. This bugfix should make sure that the non visible data is ending up in the signature response.

sheepsy90 commented 6 years ago

@hbldh Probably worth another release as this is a major flaw when people want to verify the signatures later or rely on user non visible data being in the signature

sheepsy90 commented 6 years ago

Not really sure why the build is failing - I did not find any related tests for this.

hbldh commented 6 years ago

That was an unfortunate copy-paste error I believe; good that you caught it. Thank you!

There is some strangeness with the CI systems apparently. Hopefully I will get some free time to address that and draft a new release tomorrow.

hbldh commented 6 years ago

Merged this and fixed CI problems. Will make new release to PyPI soon.

hbldh commented 6 years ago

New version including your PR is now present on PyPI.