Closed ralequi closed 4 years ago
Added some minor fixes/workarounds for some dot versions
I would prefer to made a different PR, but was difficult as I have to touch (also) code that is in this PR.
Merging #31 into master will increase coverage by
8.56%
. The diff coverage is95.83%
.
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 68.64% 77.21% +8.56%
==========================================
Files 23 23
Lines 574 588 +14
==========================================
+ Hits 394 454 +60
+ Misses 180 134 -46
Impacted Files | Coverage Δ | |
---|---|---|
graphviz2drawio/mx/CurveFactory.py | 95.65% <100%> (+1.53%) |
:arrow_up: |
graphviz2drawio/mx/Curve.py | 68% <100%> (+1.33%) |
:arrow_up: |
graphviz2drawio/mx/Styles.py | 40% <100%> (ø) |
:arrow_up: |
graphviz2drawio/mx/MxGraph.py | 86.95% <90%> (+4.69%) |
:arrow_up: |
graphviz2drawio/models/Rect.py | 100% <0%> (+17.85%) |
:arrow_up: |
graphviz2drawio/mx/NodeFactory.py | 92.85% <0%> (+37.5%) |
:arrow_up: |
graphviz2drawio/mx/LinearRegression.py | 96.77% <0%> (+58.06%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7c6a38f...19f6e46. Read the comment docs.
@ralequi this looks really cool, thank you! I’ll look at to get this merged in the next couple of days.
In the meantime, could you provide tests or examples? (Sorry if I missed something, writing from my phone)
@ralequi this looks really cool, thank you! I’ll look at to get this merged in the next couple of days.
In the meantime, could you provide tests or examples? (Sorry if I missed something, writing from my phone)
Hi,
That was my main idea when i see the codecov messages..., however I looked that there was only one very simple test. I can add an example and a few lines so my new lines run under the tests. In a few minutes I would commit it
Merged and cut a new release with this! Feel free to add yourself to the Authors section on the Readme 😄
Compilation issues that you should check: