hbmartin / graphviz2drawio

Convert graphviz (dot) files into draw.io / lucid (mxGraph) format
http://graphviz2drawio.rtfd.io
GNU General Public License v3.0
163 stars 33 forks source link

fix for head and tail port #34

Closed haisland0909 closed 5 days ago

haisland0909 commented 3 years ago

I got error when I write edge with headport and tailport option. The error caused by pygraphviz. When pygraphviz creates svg file from dot file with headport and tailport option, the title becomes "source:tailport->target:headport" and EdgeFactory looks it as key of edge dict.

codecov[bot] commented 3 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.81%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   76.94%   77.75%   +0.81%     
==========================================
  Files          23       23              
  Lines         590      598       +8     
==========================================
+ Hits          454      465      +11     
+ Misses        136      133       -3     
Impacted Files Coverage Δ
graphviz2drawio/mx/EdgeFactory.py 100.00% <100.00%> (ø)
graphviz2drawio/mx/MxGraph.py 88.40% <100.00%> (+1.44%) :arrow_up:
graphviz2drawio/mx/CurveFactory.py 100.00% <0.00%> (+4.34%) :arrow_up:
graphviz2drawio/mx/GraphObj.py 100.00% <0.00%> (+12.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51d3c66...bd08edf. Read the comment docs.

hbmartin commented 5 days ago

Thank you!