raucha commented 2 years ago

42

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 3.36%.

Quality metrics	Before	After	Change
Complexity	9.68 🙂	11.49 🙂	1.81 👎
Method Length	66.80 🙂	71.20 🙂	4.40 👎
Working memory	9.02 🙂	9.20 🙂	0.18 👎
Quality	61.15% 🙂	57.79% 🙂	-3.36% 👎

Other metrics	Before	After	Change
Lines	69	75	6

Changed files	Quality Before	Quality After	Quality Change
graphviz2drawio/mx/NodeFactory.py	61.15% 🙂	57.79% 🙂	-3.36% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
graphviz2drawio/mx/NodeFactory.py	NodeFactory.from_svg	17 🙂	163 😞	11 😞	44.04% 😞	Try splitting into smaller methods. Extract out complex expressions

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

hbmartin commented 3 months ago

Thank you!