hbmartin / graphviz2drawio

Convert graphviz (dot) files into draw.io / lucid (mxGraph) format
http://graphviz2drawio.rtfd.io
GNU General Public License v3.0
163 stars 33 forks source link

Typo leads to error: UnboundLocalError: local variable 'cb' referenced before assignment. #52

Closed altre closed 5 days ago

altre commented 1 year ago

Thanks for this project! There was an indenting typo leading to an error: UnboundLocalError: local variable 'cb' referenced before assignment. Could you merge and push to pipy otherwise I can't use the current verison?

sourcery-ai[bot] commented 1 year ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.12%.

Quality metrics Before After Change
Complexity 3.83 ⭐ 3.95 ⭐ 0.12 👎
Method Length 74.90 🙂 74.90 🙂 0.00
Working memory 8.54 🙂 8.54 🙂 0.00
Quality 68.71% 🙂 68.59% 🙂 -0.12% 👎
Other metrics Before After Change
Lines 114 114 0
Changed files Quality Before Quality After Quality Change
graphviz2drawio/mx/MxGraph.py 68.71% 🙂 68.59% 🙂 -0.12% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
graphviz2drawio/mx/MxGraph.py MxGraph.get_edge_style 8 ⭐ 164 😞 13 😞 48.45% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

hbmartin commented 5 days ago

Thank you! Cherry-picked this in https://github.com/hbmartin/graphviz2drawio/commit/c50ef77778f402e045d2f07a19f652d90a0c523c due to conflicts