hbons / Dazzle

A script to easily set up a SparkleShare host
158 stars 58 forks source link

Restarting ssh considered harmful #11

Closed realdadfish closed 11 years ago

realdadfish commented 11 years ago

In the past I mistakenly used to restart ssh while still being connected via ssh. Of course this immediately killed my active console connection and sometimes even left me alone without being able to contact my server at all when sshd did not came up properly again.

Time passed and now - as a seasoned Unix user - I am aware that most ssh init scripts provide a reload command that avoids the aforementioned nastiness. It keeps active ssh connections alive and only applies the configuration changes to new connections.

I'd argue that it would be a good choice to do that by default in dazzle.sh as well...

hbons commented 11 years ago

good point. i haven't had any trouble reloading SSH my self whilst connected, but i can imagine this can cause nasty problems. we should look into using that reload command or at least ask the user whether SSH should be restarted.

hbons commented 11 years ago

it uses the reload command in master now. thanks for the tip!