search

hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.88k stars 576 forks source link

Link on "About SparkleShare > Credits" is broken #1848

Closed gmacario closed 6 years ago

gmacario commented 6 years ago

Excerpt from ~/.config/org.sparkleshare.SparkleShare/logs/:

05:39:33 Environment | SparkleShare 2.0.1
05:39:33 Environment | Git LFS 2.3.4
05:39:33 Environment | Git 2.15.1
05:39:33 Environment | macOS 10.13.4 (High Sierra)

What happened:

I installed SparkleShare version 2.0.1 on my MacBook Pro and eventually managed to set it up - I struggled a little bit until I realized it creates another SSH key and does not use the one I usually use on my command line git client.

After the installation was successful I opened the SparkleShare menu and clicked on the "About SparkleShare" menu, obtaining the following dialog box

screenshot 2018-05-27 06 24 34

When clicking the "Credits" link, my browser opens the https://github.com/hbons/SparkleShare/blob/master/legal/Authors.txt URL which displays the following page

screenshot 2018-05-27 06 26 55

What I expected to happen:

The list of people I should be grateful to will appear

This happens when:

  1. Install SparkleShare
  2. Click on SparkleShare > About SparkleShare
  3. Click on "Credits"
gmacario commented 6 years ago

By inspecting the source code on the master branch it looks like the "Credits" link now displays inline text and does no longer opens a page on GitHub.

I will close the issue and have created #1849, since the bug seems already fixed on master.

Anyway, by reading the code at https://github.com/hbons/SparkleShare/blob/master/SparkleShare/Mac/UserInterface/About.cs#L104-L113 I also got the answer to my original question:

The list of people I should be grateful to will appear

Thanks A LOT, @hbons and others 😉