hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.88k stars 579 forks source link

Flatpak version blocks forever on encrypted keys #1868

Closed ocrete closed 5 years ago

ocrete commented 5 years ago

What happened:

  1. I started the Flatpak version of 3.28.0 because I need the indicator support because SparkleShare doesn't use a GNOME 3 design.
  2. It creates a ssh key which I can't use, so I just put my existing key in the sparkleshare config directory.
  3. When I try to clone the repo, it just freezes waiting for the password to unlock the key.. with no feedback (that's bad!)

What I expected to happen:

  1. It should just clone it.
  2. It should use the system's ssh-agent (see https://github.com/flatpak/flatpak/issues/1438)
hbons commented 5 years ago

Sparkleshare used an ssh-agent before, but it never worked well. SparkleShare requires an unlocked key.

Any reason why you can’t use the provided key?

ocrete commented 5 years ago

I feel that putting my key unlocked on the drive is a nasty security risk and I'm pretty sure it's very much against our corporate security policy. What problems did you have with ssh agent before?

hbons commented 5 years ago

I don’t recall what exactly, but most had to do with having a shared SSH configuration with other apps. There’s an issue open for storing the key in a secure store and only getting it when needed, but I’m not sure how much it would help as the key still needs to be read from disc for a short amount of time.

hbons commented 5 years ago

Duplicate of #1780.