search

hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.87k stars 579 forks source link

Migrate to appindicator-sharp-0.1 #1874

Open evelikov opened 5 years ago

evelikov commented 5 years ago

Currently SS uses appindicator3-sharp-0.1 when it's available.

That comes from the Ubuntu package libappindicator3-0.1-cil based on the code in [1]. That project has been effectively dead for at least 2 years now.

Only Ubuntu carries the package around, where SS is the only user in the whole of Ubuntu.

Every other distribution has appindicator-sharp-0.1 (notice the missing 3) based on [2]. Can we opt for that instead? This way everyone will make use of the functionality, plus it will save (fix) reports like https://github.com/hbons/SparkleShare/issues/1790

Thanks Emil

[1] https://github.com/stsundermann/appindicator-sharp/commits/master [2] https://launchpad.net/libappindicator

hbons commented 5 years ago

Does the project in [2] contains the csharp bindings?

hbons commented 5 years ago

Ok, so I see this is the original upstream and it includes the csharp bindings as well. I've used the appindicator-sharp3 bindings because that when porting to GTK3 at the time, the original bindings did not work for some reason.

I'm open to use the original again if someone can test if it works. The status icon code is relatively simple.