search

hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.88k stars 579 forks source link

SparkleShare (v3.28) doesn't ask for password on encrypted repository #1879

Open ianchanning opened 5 years ago

ianchanning commented 5 years ago

You can find session logs by date and version information in:

What happened:

Synced encrypted repo created in v3.28, no password requested, the repo is synced but all files are encrypted.

This is similar to #1854 but in this case I have made sure that the encrypted repository was created with v3.28 as well.

What I expected to happen:

The application asks for a password and decrypts the repo locally.

This happens when:

  1. On Ubuntu 18.04 machine with SparkleShare v3.28 create encrypted project
  2. Brand new installation on Fedora
  3. Added Computer ID to bitbucket
  4. Synced Remote Project...
  5. Specify Bitbucket project

log

12:18:17 Environment | SparkleShare 3.28.0 (Flatpak)
12:18:17 Environment | Git LFS 2.4.0
12:18:17 Environment | Git 2.17.0
12:18:17 Environment | GNOME (Linux 4.18.17.200)
12:18:17 Cmd | gio set "/home/ian/SparkleShare" metadata::custom-icon-name org.sparkleshare.SparkleShare
12:18:17 Environment | GTK+ 3.22.30
12:18:17 Environment | Status Icon: AppIndicator
12:18:54 Fetcher | /home/ian/.config/org.sparkleshare.SparkleShare/tmp/sparkle | Fetching folder: ssh://git@bitbucket.org/icc97/sparkle
12:18:54 Auth | Fetching host key for bitbucket.org
12:18:54 Cmd | ssh-keyscan -t rsa -p 22 bitbucket.org
12:18:55 Auth | Fingerprint matches
12:18:55 Auth | Accepted host key for bitbucket.org
12:18:55 Cmd | tmp | git ls-remote --heads "ssh://git@bitbucket.org/icc97/sparkle"
12:18:56 Cmd | tmp | git clone --progress --no-checkout --depth=1 "ssh://git@bitbucket.org/icc97/sparkle" "/home/ian/.config/org.sparkleshare.SparkleShare/tmp/sparkle"
12:18:56 Git | Cloning into '/home/ian/.config/org.sparkleshare.SparkleShare/tmp/sparkle'...
12:18:56 Git | warning: templates not found //share/git-core/templates
12:18:56 Git | Warning: Permanently added the RSA host key for IP address '2406:da00:ff00::22c0:3470' to the list of known hosts.
12:18:58 Git | remote: Counting objects: 35, done.        
12:18:58 Git | remote: Total 35 (delta 0), reused 0 (delta 0)        
12:19:00 Fetcher | Finished
12:19:00 Cmd | sparkle | git rev-parse HEAD
12:19:00 Cmd | sparkle | git config core.autocrlf input
12:19:00 Cmd | sparkle | git config core.quotepath false
12:19:00 Cmd | sparkle | git config core.precomposeunicode true
12:19:00 Cmd | sparkle | git config core.ignorecase false
12:19:00 Cmd | sparkle | git config core.filemode false
12:19:00 Cmd | sparkle | git config core.safecrlf false
12:19:00 Cmd | sparkle | git config core.excludesfile ""
12:19:00 Cmd | sparkle | git config core.packedGitLimit 128m
12:19:00 Cmd | sparkle | git config core.packedGitWindowSize 128m
12:19:00 Cmd | sparkle | git config pack.deltaCacheSize 128m
12:19:00 Cmd | sparkle | git config pack.packSizeLimit 128m
12:19:00 Cmd | sparkle | git config pack.windowMemory 128m
12:19:00 Cmd | sparkle | git config push.default matching
12:19:00 Cmd | sparkle | git config filter.lfs.required true
12:19:00 Cmd | sparkle | git config filter.lfs.clean 'git-lfs clean %f'
12:19:00 Cmd | sparkle | git config filter.lfs.smudge "env GIT_SSH_COMMAND='ssh -i /home/ian/.config/org.sparkleshare.SparkleShare/ssh/2018-11-11_11h52.key -o UserKnownHostsFile=/home/ian/.config/org.sparkleshare.SparkleShare/ssh/known_hosts -o IdentitiesOnly=yes -o PasswordAuthentication=no -F /dev/null' git-lfs smudge %f"
12:19:00 Cmd | sparkle | git rev-parse HEAD
12:19:00 Cmd | sparkle | git show-ref --verify --quiet refs/heads/SparkleShare
12:19:00 Cmd | sparkle | git checkout --quiet --force HEAD
12:19:00 Config | Wrote to '/home/ian/.config/org.sparkleshare.SparkleShare/projects.xml'
12:19:00 /home/ian/SparkleShare/bitbucket.org/sparkle | Initializing...
12:19:00 Cmd | sparkle | git config core.ignorecase false
12:19:00 Cmd | sparkle | git config remote.origin.url "ssh://git@bitbucket.org/icc97/sparkle"
12:19:00 Cmd | sparkle | git config core.sshCommand ssh -i /home/ian/.config/org.sparkleshare.SparkleShare/ssh/2018-11-11_11h52.key -o UserKnownHostsFile=/home/ian/.config/org.sparkleshare.SparkleShare/ssh/known_hosts -o IdentitiesOnly=yes -o PasswordAuthentication=no -F /dev/null
12:19:00 Cmd | chmod 700 /home/ian/SparkleShare/bitbucket.org/sparkle/.git/hooks/pre-push
12:19:00 Cmd | sparkle | git --no-pager log --since=1.month --name-status --date=iso --find-renames --no-merges --no-color
12:19:00 Git | sparkle | Checking for remote changes...
12:19:00 Cmd | sparkle | git rev-parse HEAD
12:19:00 Cmd | sparkle | git config core.ignorecase true
12:19:00 Cmd | sparkle | git config core.ignorecase false
12:19:00 Cmd | sparkle | git rev-parse --abbrev-ref HEAD
12:19:00 Cmd | sparkle | git ls-remote --heads --exit-code origin master
12:19:01 Git | sparkle | No remote changes, local+remote: 8381bd5dd98ded3c9917f69a8011b9c08d6dc955
12:19:01 Cmd | sparkle | git status --porcelain
12:19:17 Fetcher | /home/ian/.config/org.sparkleshare.SparkleShare/tmp/sparklebox | Fetching folder: ssh://git@bitbucket.org/icc97/sparklebox
12:19:17 Auth | Fetching host key for bitbucket.org
12:19:17 Cmd | ssh-keyscan -t rsa -p 22 bitbucket.org
12:19:17 Auth | Fingerprint matches
12:19:17 Cmd | tmp | git ls-remote --heads "ssh://git@bitbucket.org/icc97/sparklebox"
12:19:19 Cmd | tmp | git clone --progress --no-checkout --depth=1 "ssh://git@bitbucket.org/icc97/sparklebox" "/home/ian/.config/org.sparkleshare.SparkleShare/tmp/sparklebox"
12:19:19 Git | Cloning into '/home/ian/.config/org.sparkleshare.SparkleShare/tmp/sparklebox'...
12:19:19 Git | warning: templates not found //share/git-core/templates
12:19:20 Git | remote: Counting objects: 6, done.        
12:19:21 Git | remote: Total 6 (delta 0), reused 0 (delta 0)        
12:19:22 Fetcher | Finished
12:19:22 Cmd | sparklebox | git rev-parse HEAD
12:19:22 Cmd | sparklebox | git config core.autocrlf input
12:19:22 Cmd | sparklebox | git config core.quotepath false
12:19:22 Cmd | sparklebox | git config core.precomposeunicode true
12:19:22 Cmd | sparklebox | git config core.ignorecase false
12:19:22 Cmd | sparklebox | git config core.filemode false
12:19:22 Cmd | sparklebox | git config core.safecrlf false
12:19:22 Cmd | sparklebox | git config core.excludesfile ""
12:19:22 Cmd | sparklebox | git config core.packedGitLimit 128m
12:19:22 Cmd | sparklebox | git config core.packedGitWindowSize 128m
12:19:22 Cmd | sparklebox | git config pack.deltaCacheSize 128m
12:19:22 Cmd | sparklebox | git config pack.packSizeLimit 128m
12:19:22 Cmd | sparklebox | git config pack.windowMemory 128m
12:19:22 Cmd | sparklebox | git config push.default matching
12:19:22 Cmd | sparklebox | git config filter.lfs.required true
12:19:22 Cmd | sparklebox | git config filter.lfs.clean 'git-lfs clean %f'
12:19:22 Cmd | sparklebox | git config filter.lfs.smudge "env GIT_SSH_COMMAND='ssh -i /home/ian/.config/org.sparkleshare.SparkleShare/ssh/2018-11-11_11h52.key -o UserKnownHostsFile=/home/ian/.config/org.sparkleshare.SparkleShare/ssh/known_hosts -o IdentitiesOnly=yes -o PasswordAuthentication=no -F /dev/null' git-lfs smudge %f"
12:19:22 Cmd | sparklebox | git rev-parse HEAD
12:19:22 Cmd | sparklebox | git show-ref --verify --quiet refs/heads/SparkleShare
12:19:22 Cmd | sparklebox | git checkout --quiet --force HEAD
12:19:22 Config | Wrote to '/home/ian/.config/org.sparkleshare.SparkleShare/projects.xml'
12:19:22 /home/ian/SparkleShare/bitbucket.org/sparklebox | Initializing...
12:19:22 Cmd | sparklebox | git config core.ignorecase false
12:19:22 Cmd | sparklebox | git config remote.origin.url "ssh://git@bitbucket.org/icc97/sparklebox"
12:19:22 Cmd | sparklebox | git config core.sshCommand ssh -i /home/ian/.config/org.sparkleshare.SparkleShare/ssh/2018-11-11_11h52.key -o UserKnownHostsFile=/home/ian/.config/org.sparkleshare.SparkleShare/ssh/known_hosts -o IdentitiesOnly=yes -o PasswordAuthentication=no -F /dev/null
12:19:22 Cmd | chmod 700 /home/ian/SparkleShare/bitbucket.org/sparklebox/.git/hooks/pre-push
12:19:22 Cmd | sparklebox | git --no-pager log --since=1.month --name-status --date=iso --find-renames --no-merges --no-color
12:19:22 Git | sparklebox | Checking for remote changes...
12:19:22 Cmd | sparklebox | git rev-parse HEAD
12:19:22 Cmd | sparklebox | git config core.ignorecase true
12:19:22 Cmd | sparklebox | git config core.ignorecase false
12:19:22 Cmd | sparklebox | git rev-parse --abbrev-ref HEAD
12:19:22 Cmd | sparklebox | git ls-remote --heads --exit-code origin master
12:19:24 Git | sparklebox | No remote changes, local+remote: 81cb3920ba5e8108121b8113881cc0a6fe7399d0
12:19:24 Cmd | sparklebox | git status --porcelain
12:20:44 UI | Failed to download https://www.sparkleshare.org/version: Error: TrustFailure (Ssl error:1000007d:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED)   at System.Net.WebClient.DownloadDataInternal (System.Uri address, System.Net.WebRequest& request) [0x0008a] in <f8255d9ef0594d18ae2c0d97286b9a80>:0 
  at System.Net.WebClient.DownloadString (System.Uri address) [0x00027] in <f8255d9ef0594d18ae2c0d97286b9a80>:0 
  at (wrapper remoting-invoke-with-check) System.Net.WebClient:DownloadString (System.Uri)
  at SparkleShare.AboutController.CheckForNewVersion () [0x0002d] in <cc5d93e6b2c7414faa51c74d720c34aa>:0

flatpak list -d

Ref                                             Origin  Active commit Latest commit Installed size Options       
org.sparkleshare.SparkleShare/x86_64/stable     flathub 250f3551bd14  -             280.9 MB       system,current
org.freedesktop.Platform.VAAPI.Intel/x86_64/1.6 flathub 82006efc71d3  -               8.7 MB       system,runtime
org.freedesktop.Platform.ffmpeg/x86_64/1.6      flathub d757f762489e  -               7.7 MB       system,runtime
org.gnome.Platform/x86_64/3.28                  flathub 6d1d0ebbd724  -               1.3 GB       system,runtime
TwlyY29 commented 5 years ago

Hi, I have the same issue with the same version of SparkleShare (flatpak list -d gives the same commit ID). I have used dazzle to create the repository - once using dazzle create and once using dazzle create-encrypted. Both times, SparkleShare has asked for the password only on the first client I linked. Subsequent links succeed, but files are encrypted...

Edit: It is the same OpenSSL-version on all clients (1.1.0g) - in reference to issue #1855

MalteKiefer commented 4 years ago

Do you get a chance to access the files?

ianchanning commented 4 years ago

@MalteKiefer I think I just threw away the repository and switched to an un-encrypted repository

torakiki commented 2 years ago

I've the same issue. I just spent an hour or two figuring out what was happening and in the end it seems I cannot decrypt the existing repo