hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.88k stars 576 forks source link

Mark unsynced commits as so in recent changes #1893

Open Ppjet6 opened 5 years ago

Ppjet6 commented 5 years ago

It often happens that SparkleShare fails to sync for different reasons, and while these problems should be addressed (in separate issues), it is never obvious to users what has others can see or not.

This is a feature request to add some visual cue in the Recent Changes view, for users to know what's still not being sent to the server.

Ppjet6 commented 5 years ago

Possible duplicate of #1746, which says:

SparkleShare is able to indicate this via an ! icon in the SparkleShare Projects list

I have actually never seen this, and most of the time sparkleshare is stuck somehow there no indication whatsoever. I'm curious if I'm doing anything wrong.

hbons commented 5 years ago

which version are you using? the instanced files marked in the a Recent window is definitely something that SparkleShare should have.

Ppjet6 commented 5 years ago

I'm running off master.

My bad, I was looking at the wrong place! There is indeed a marker in the tray menu that appears with a pretty simple case.

I do not see anything in the Recent Changes window.

This is a pretty contrived example though imho, it is pretty rare for me to be offline, and I am not sure how to reproduce otherwise. I can think of a few other cases where it's not reporting it, but I'm still trying to reproduce and isolate them, to provide some logs.

In any case for this particular issue, I think it would be more obvious for users to have some indication in the Recent Changes, to see what commit has been pushed and what commit hasn't, if it's not already the case. If so please excuse me again. It'd be great if you could provide a way to reproduce.

EDIT: I am running off master, on Debian stretch / GNOME / x11.