search

hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.88k stars 577 forks source link

Support for Keybase encrypted git repositories #1920

Open deobald opened 5 years ago

deobald commented 5 years ago 
16:45:53 Fetcher | /Users/steven/.config/org.sparkleshare.SparkleShare/tmp/projects | Fetching folder: ssh://storage@team/4440.friends/projects
16:45:53 Auth | Fetching host key for team
16:45:53 Cmd | ssh-keyscan -t rsa -p 22 team
16:45:53 Auth | Could not fetch host key
16:45:54 Fetcher | Failed

What happened:

I tried checking out a keybase encrypted git repo. It fails with a Could not fetch host key error.

What I expected to happen:

Honestly, I'd be a bit surprised if this worked out of the box. Keybase encrypted git uses git-remote-helpers (https://keybase.io/blog/encrypted-git-for-everyone) which may require a bit of extra work on SparkleShare's part.

This happens when:

  1. Sync remote project
  2. Own server
  3. Address: keybase://team and Remote Path: /my-team/my-repo

If keybase repos can be supported, it would be best if they had a pre-configured checkout, similar to what exists for Bitbucket, GitHub, and GitLab.

MalteKiefer commented 3 years ago

To support the address no problem, to implement the helper is difficult. Because keybase uses for that a golang script, that means we must check if the host system has golang installed and must pull all requirements. SS uses pure git and for encryption openssl, what every system has pre installed.

deobald commented 3 years ago

That's totally fair and makes sense. Thanks for the reply! Feel free to drop this issue if it feels like something SS can't support.