hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.87k stars 579 forks source link

The flatpak UI does not tell you where to find your client ID as part of on-boarding #1951

Open eriknelson opened 3 years ago

eriknelson commented 3 years ago

OS: Arch Linux DE: i3 Install: Flatpak org.sparkleshare.SparkleShare 3.28.0

What happened:

I honestly may have just missed this, but while kicking the tires on SparkleShare for the first time, I installed the flatpak and ran it from the cli. I was promped for my server's details, and of course it failed to connect. I realized I needed to "link" my client with my host via dazzle.sh link, and it asked for my "client ID". I honestly had no idea what his was until I realized through the client's stdout that it was in the applet, and it was a simple ssh pubkey.

What I expected to happen:

I would expect to see this as part of the onboarding wizard and not hidden in the applet.

This happens when:

Install new flatpak installation and try to connect to a self-hosted sparkleshare host.

hbons commented 3 years ago

It should be on the last page of the onboarding wizard? Maybe I changed it, I don't remember. :)

eriknelson commented 3 years ago

I'll update with some screenshots when I get a sec so I can show what I'm seeing.

eriknelson commented 3 years ago

Here's the onboarding experience starting fresh with the flatpak on my Fedora 32 machine, I have an Rpi acting as a sparkshare host that was set up with dazzle:

screen1

screen2

errormodal

It's not until this 3rd step I realize, oh I didn't even realize I needed to add a client ID...where do I get a client ID?

I think I read somewhere in the logs of the terminal output that it was in the tray icon, but it's not called out at any point during that onboarding.

hbons commented 3 years ago

Thanks for the screenshots. I remember now! I've made some changes to the flow because I wanted to automatically upload the key for known services, and the Own Server page would show your SSH key. I think this was only partly implemented and the rest is still in a branch...