hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.88k stars 577 forks source link

Encoding problems on macOS #1966

Open markusstoll opened 3 years ago

markusstoll commented 3 years ago

When compiling with a fresh VisualStudio installation on macOS BigSur it turns out, the default encoding is set to ASCII which is causing some problems with your current encoding handling. Especially the path conversions for the changes view do make things worse. Before trying to build a pull request - for which runtime is this actually needed?

markusstoll commented 3 years ago

Did some research - this handling was introduced for the Windows version. I will create a PR where my fix will only affect the macOS version and leave the Windows version untouched

markusstoll commented 3 years ago

I guess this issue can be closed