search

hbons / SparkleShare

Share and collaborate by syncing with any Git repository instantly. Linux, macOS, and Windows.
https://sparkleshare.org
Other
4.87k stars 579 forks source link

macOS increase .Net version to 4.8 #1968

Closed markusstoll closed 3 years ago

hbons commented 3 years ago

Looks like this breaks the CI. Is this really needed right now?

markusstoll commented 3 years ago

Hm, could it be that on travis the latest version of VisualStudio is missing?

I guess its not really needed, but..

Until now me and my colleagues have been using SparkleShare 3.28 and we sometimes do observe some strange phenomena. This is the whole reason why I was digging into building Version 3.38 and fixing all bugs I observed. By bumping the versions for git and .Net I just wanted to avoid having unnecessary bugs from old stuff. So maybe .Net 4.7.2 is good enough...

knocte commented 3 years ago

.NET4.7.2->4.8 doesn't really introduce bugfixes but features, and not all versions of Mono support 4.8 (e.g. versions from stable Debian). IMO this change should only happen if it fixes a specific problem, not "just in case".

markusstoll commented 3 years ago

@knocte My proposed change is related to macOS only - still I think .Net 4.5 is way too old

knocte commented 3 years ago

I've never thought of .NET Framework versions as old or new. They are just versions. What is usually too old are the runtimes that run these .NETFramework versions (e.g. Mono).

But anyway now I checked the diff and see you only changing this in one project, which shouldn't affect Linux. However the fact that it breaks CI is concerning (maybe because the Mono version that runs on Mac still doesn't support 4.8). Maybe upgrade to 4.7.2 to see if it fixes CI?

markusstoll commented 3 years ago

Ok, Travis does not know about .Net V4.7.2 either - so I guess we close this for now as long this not really needed