hborawski / DominionCompanion

Companion app for card game Dominion
GNU General Public License v3.0
1 stars 1 forks source link

German Translation #25

Open bennokress opened 3 years ago

bennokress commented 3 years ago

I had the same idea as you to write a Dominion Companion iOS app before you released yours (I even named it the same). Your app is really great and it discouraged me to continue mine … thanks for that 😆 Since some graphics in the repository might violate copyrights, I just invited you to have a look and left it private for now. Feel free to use stuff if you like.

I'm still liking my design and what I had planned with it, so I'm looking into adjusting my fork of your project. For that I'm first adding stuff that others might find useful too, and making it available to you via PR. Afterwards I might go into another direction with the project than what you envision.

One of those generally useful features is an easy way to add translations. Since I'm German and have all cards in German, I have to search for them when I use your deck generator. That's sometimes easy and sometimes it's not. In my project you'll find that I already have a complete list of all cards and card types as well as the expansion names as localizable strings files for the English and German language. Maybe we can find a way to incorporate it into your code, too.

bennokress commented 3 years ago

I started implementing here: https://github.com/bennokress/DominionCompanion/commits/feature/%2325-german-translation

It will be hard to find and localize all strings in the app, because they're all hardcoded so far. Also my guess is that all those explicit string comparisons will be prone to produce logical errors after switching them out. But for me personally having only the card names translated is already a huge improvement, so maybe you want to start out releasing a partially translated app and improve it by making all strings localizable over time. Your call and I'd be happy to help you ;)