search

hbrobotics / ros_arduino_bridge

ROS + Arduino = Robot
355 stars 351 forks source link

Publisher needs queue size #20

Closed gtaylor40 closed 9 years ago

gtaylor40 commented 9 years ago

Shouldn't lines such as following line 166 of arduino_sensors.py

self.pub = rospy.Publisher("~sensor/" + self.name, Range)

be changed to include queue_size as follows

self.pub = rospy.Publisher("~sensor/" + self.name, Range, queue_size=10)

as well as other similar files in the ros_arduino_bridge software?

Without the queue_size being defined, several errors were reported when executing:

roslaunch ros_arduino_python arduino.launch

mikeferguson commented 9 years ago

@gtaylor40 the queue_size thing is new in Hydro and required in Indigo and later -- so I think it just is a matter of this package having not yet been updated yet. A pull request with the required fixes is probably the best way to get them updated.

gtaylor40 commented 9 years ago

Mike,

Thanks for the info. It really tickled me to have been able to figure out how to modify the code by adding queue_size=10 in several places to allow running successfully the Arduino Bridge software and displaying Ping information. My compliments to the code developer(s) whose error message not only indicated the error, but also gave a URL that provided information as to how to correct it.

George Taylor

----- Original Message ----- From: "Michael Ferguson" notifications@github.com To: "hbrobotics/ros_arduino_bridge" ros_arduino_bridge@noreply.github.com Cc: "George Taylor" gtaylor40@comcast.net Sent: Wednesday, July 22, 2015 1:14:28 PM Subject: Re: [ros_arduino_bridge] Publisher needs queue size (#20)

@gtaylor40 the queue_size thing is new in Hydro and required in Indigo and later -- so I think it just is a matter of this package having not yet been updated yet. A pull request with the required fixes is probably the best way to get them updated.

Reply to this email directly or view it on GitHub: https://github.com/hbrobotics/ros_arduino_bridge/issues/20#issuecomment-123849239

pirobot commented 9 years ago

@gtaylor40 - the queue_size parameter has been added to the Publishers in the indigo-devel branch.