hbrobotics / ros_arduino_bridge

ROS + Arduino = Robot
355 stars 351 forks source link

Bug in execute_ack #63

Open miquelmassot opened 3 years ago

miquelmassot commented 3 years ago

Line 214 in https://github.com/hbrobotics/ros_arduino_bridge/blob/a960c8a88a6255d0104c92838045c06257c509d0/ros_arduino_python/src/ros_arduino_python/arduino_driver.py#L241 needs to be indented to increase attempts inside the while loop. Otherwise, it will infinitely be looping if the Arduino times out, replies an empty string or "Invalid command".