search

hbz / digitalisiertedrucke

Implements http://digitalisiertedrucke.de/
0 stars 0 forks source link

Redirect from old record URLs with 301 moved permanently #48

Closed fsteeg closed 7 years ago

fsteeg commented 7 years ago

Will resolve #45

dr0i commented 7 years ago

Checks failed -> reassigning

dr0i commented 7 years ago

Why do redirections another way (instead of using apache.conf as we do in all(?!) other cases)?

fsteeg commented 7 years ago

For digitalisiertedrucke the apache only provides the proxy, there are no application specific settings in the apache config. To me it feels more self-contained to have all the logic within the application, independent of the proxy. If you'd prefer the other way, I would not object if you implement a 301 redirect on the apache level (note however that the other parts of this pull request are still required, in particular support for IDs without P or D and the somewhat unrelated zvdd.hbz.k.de special case).

dr0i commented 7 years ago

I find it more confusing doing things differently, especially when later tracing bugs, but as I have not the time to implement this just take this as a note. +1 for deploying

fsteeg commented 7 years ago

Actually merged, see https://github.com/hbz/digitalisiertedrucke/commits/master