search

hbz / geodata

Microservice for geo information enrichment. Deprecated in favor of https://github.com/pelias.
Other
1 stars 2 forks source link

Set up Travis CI #11

Closed fsteeg closed 9 years ago

fsteeg commented 9 years ago

To build and test automatically in pull requests.

dr0i commented 9 years ago

Set up travis. Please @philboeselager review.

philboeselager commented 9 years ago

The travis build still fails (https://travis-ci.org/hbz/geodata/builds/88792249#L692) due to the Elasticsearch setting (https://github.com/hbz/geodata/blob/issue-11-setUpTravis/app/controllers/geo/GeoElasticsearch.java#L25). The Elasticsearch configuration chosen can easily be amended to Travis Elasticsearch defaults.

dr0i commented 9 years ago

Yes, I think the code must be fixed as you say. The issue of this ticket was just to set up travis, not to make the code work in travis, I think. So I would say this ticket can be closed (as long as I set up travis correctly).

fsteeg commented 9 years ago

I think we should leave this open and only close it when the build works with travis in https://github.com/hbz/geodata/issues/14.