search

hbz / laser-ygor

A spare hand when needed ..
0 stars 1 forks source link

ISIL (ZDB Sigel) #102

Closed darupp closed 4 years ago

darupp commented 5 years ago

The manual input-field for the ISIL (ZDB-Sigel) is not processed correctly: In GOKb, it is put under "Alternate Name" as alternate package name and not - as it should be - as package identifier under the Namespace ISIL.

hemmefelix commented 5 years ago

Fixing this issue seems important as more librarians are going to use the package upload via Ygor. Example: Partial packages with different names are thrown together if they have the same ZDB ISIL. Springer:Ebooks:ComputerScience:2017, 2018 and 2019 (ZDB-2-SCS) were imported individually and landed in one package in GOKbT. This is due to secondary matching on alternative names.

darupp commented 4 years ago

Reopened

In 0.88 of YGOR the ZDB Sigel is STILL not processed or does at least not appear in the package JSON.

Tested on phaeton-dev

  "packageHeader" : {
    "breakable" : "No",
    "consistent" : "Yes",
    "fixed" : "Yes",
    "global" : "Global",
    "listStatus" : "In Progress",
    "nominalProvider" : "Emerald Group Publishing Limited",
    "paymentType" : "",
    "scope" : "",
    "userListVerifier" : "",
    "name" : "Emerald Management 120 KURZ Testpaket 2020-03-13",
    "nominalPlatform" : {
      "name" : "Emerald Insight",
      "primaryUrl" : "https://www.emerald.com/insight"
    },
    "curatoryGroups" : [ "hbz" ],
    "identifiers" : [ {
      "type" : "emerald",
      "value" : "EMX120"
    } ],
    "additionalProperties" : [ ],
    "soure" : { }
},
darupp commented 4 years ago

As of YGOR 0.89 ZDB Sigel is still not processed.

philboeselager commented 4 years ago

@darupp Which result do you expect? Current result is

"packageHeader" : {
  ...
  "identifiers" : [ {
    "type" : "isil",
    "value" : "the value that you've entered"
  } ],
  ...
}

in package Json.

darupp commented 4 years ago

This would be correct, but in my test cases, this does not work. Test scenario: Titel = Pakettitel Paketsigel (ISIL) der ZDB = ZDB-55-EM120X Interner Paket-Identifikator = EMX120X // Namespace: emerald GOKb Plattform = Emerald Insight GOKb Provider= Emerald Group Publishing Limited Namensraum für proprietären Titel-Identifkator des Providers (title_id)= emerald

 "identifiers" : [ {
      "type" : "emerald",
      "value" : "EMX120X"
    } ],

EM 120.zip

Could it be that it doesn't work if an Interner Paket-Identifikator is set?