hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
25 stars 5 forks source link

Create sameAs links to DNB/GND for entries not covered in EntityFacts #152

Open acka47 opened 6 years ago

acka47 commented 6 years ago

As reported in #151 these are currently missing:

there are some examples that are not in EntityFacts and thus don't have the sameAs link to DNB/GND, e.g. http://lobid.org/gnd/16255670-6

We should automatically add the `sameAslinks, for the example resource this would be:

{
  "sameAs":[
    {
      "collection":{
        "abbr":"DNB",
        "name":"Gemeinsame Normdatei (GND) im Katalog der Deutschen Nationalbibliothek",
        "publisher":"Deutsche Nationalbibliothek",
        "icon":"http://www.dnb.de/SiteGlobals/StyleBundles/Bilder/favicon.png?__blob=normal&v=1",
        "id":"http://www.wikidata.org/entity/Q36578"
      },
      "id":"http://d-nb.info/gnd/16255670-6/about"
    }
  ]
}
fsteeg commented 2 years ago

Seems to be resolved with #219, see sameAs in http://lobid.org/gnd/16255670-6 (json).

acka47 commented 2 years ago

Unfortunately, I can not test this properly as the problem described in #151 seems to have resurfaced. Concretely, this means that the query NOT sameAs.collection.id:"http://www.wikidata.org/entity/Q36578" gives back lots of resources that actually have exactly the information I wanted to exclude with the NOT...

acka47 commented 1 year ago

Unfortunately, I can not test this properly as the problem described in https://github.com/hbz/lobid-gnd/issues/151 seems to have resurfaced. Concretely, this means that the query NOT sameAs.collection.id:"http://www.wikidata.org/entity/Q36578" gives back lots of resources that actually have exactly the information I wanted to exclude with the NOT...

The query works now. Though, the number has decreased a lot compared to 2019 where it affected half of the entries, there are still [933.350 entries without the relevant sameAs information in the JSON. However, for those it is at least shown in the HTML.