hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
24 stars 5 forks source link

Support GET for reconciliation requests #175

Closed fsteeg closed 5 years ago

fsteeg commented 5 years ago

Internally OpenRefine uses POST with the query data in the request body.

The wiki however describes GET with a queries parameter:

https://github.com/OpenRefine/OpenRefine/wiki/Reconciliation-Service-API#multiple-query-mode

We should probably support both.

fsteeg commented 5 years ago

Required for testing with https://github.com/reconciliation-api/testbench, which is useful e.g. for https://github.com/hbz/lobid-gnd/issues/206.

fsteeg commented 5 years ago

Deployed to test, see: https://test.lobid.org/gnd/reconcile?queries={"q0":{"query":"Twain"}}

To test in the reconciliation service test bench:

acka47 commented 5 years ago

I tested it in the reconciliation service test bench and it worked. +1