search

hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
24 stars 5 forks source link

Fix reconciliation query properties search #224

Closed fsteeg closed 4 years ago

fsteeg commented 4 years ago

When sending additional properties during reconciliation ("Also use relevant details from other columns"), the plain property is used in the internal field query. This only makes sense for *AsLiteral fields. For others, we need to append .id or .label, e.g. affiliation.id:"http://d-nb.info/gnd/2022139-3".

acka47 commented 4 years ago

I suggest translating this into an OR query so that both IDs and literals work, e.g. affiliation.id:"http://d-nb.info/gnd/2022139-3" OR affiliation.label:"http://d-nb.info/gnd/2022139-3"

fsteeg commented 4 years ago

Deployed to test, see https://test.lobid.org/gnd/reconcile

I suggest translating this into an OR query so that both IDs and literals work

I check the value and use .id if it starts with http, otherwise .label, see https://github.com/hbz/lobid-gnd/commit/a734854f84bb1eca95d1f17e3802556aef1d60be.

acka47 commented 4 years ago

+1 Works like a charm now.