search

hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
24 stars 5 forks source link

Use generic temporaryName property instead of specific ones #227

Open acka47 opened 4 years ago

acka47 commented 4 years ago

As with preferredName, we should only use temporaryName in lobid-gnd data for all these properties: temporaryName, temporaryNameOfTheConferenceOrEvent, temporaryNameOfTheCorporateBody, temporaryNameOfThePlaceOrGeographicName.

fsteeg commented 4 years ago

That's a good idea too, but what we discussed was about abbreviatedNameForThe*.

acka47 commented 4 years ago

That's a good idea too, but what we discussed was about abbreviatedNameForThe*.

Yes, but we can already implement this as a generic property exists. For abbreviatedNameForThe* I will first open an issue at DNB to add the generic property in the first place.

fsteeg commented 1 year ago

After looking at this, I now think https://github.com/hbz/lobid-gnd/issues/229, like this here, is actually about using the generic property (abbreviatedName there, temporaryName here), and filling it with values that in the DNB data are stored in the specific fields. Given that we have some unification with the DNB data on the horizon, and this has not been driven by a concrete user request, I think we should not invest the time to implement this right now.

acka47 commented 1 year ago

Ok. Then we can close this issue for now?

acka47 commented 1 year ago

Shouldn't we include temporaryName, temporaryNameOfTheConferenceOrEvent, temporaryNameOfTheCorporateBody, temporaryNameOfThePlaceOrGeographicName for reconciliation queries then? Or is this already the case. Doesn't seem so when looking at #228.

fsteeg commented 1 year ago

Yes, good catch! We only had temporaryName (which isn't used in the data). Added the specific ones in https://github.com/hbz/lobid-gnd/commit/bd52135562e0c5a6a02fba259986fb7957e0eb60.

acka47 commented 1 year ago

As discussed offline, we aim at the consistent approach for all name properties, i.e. using *Name only and getting rid of specific versions like *NameOfTheCorporateBody but will not implement this right now.