search

hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
24 stars 5 forks source link

Update details.scala.html #322

Closed LibrErli closed 1 year ago

LibrErli commented 1 year ago

Resolves #286: bringing the entity-type badge and ld-json link icon "one row" higher than the h1-tag, which should contain only the preferred name, it makes it much easier to copy and paste the preferred name with double click from the browser view.

acka47 commented 1 year ago

Thanks for the pull request, @fsteeg . Assigning @fsteeg for review and – if everything is fine – deployment.

LibrErli commented 1 year ago

thank you! one thing missing is some styling about the ld-json icon. without the <h1>-tag the icon is very small. in my pull request i don't want to add element based styling, maybe you have a certain class which handles this issue already.

fsteeg commented 1 year ago

Thank you @LibrErli for the pull request!

one thing missing is some styling about the ld-json icon. without the <h1>-tag the icon is very small.

And what's worse in my opinion, the type labels and subtitle become very small. I also like how currently the type labels are next to the name (actually labelling it) and how bootstrap formats the subtitle (size, font color). Therefore I'd prefer to keep both inside the h1 tag.

To address your use case, how about we add direct support for copying to the clipboard when clicking the title (like the functionality on the URI clipboard icon)? I've deployed that to our test system for you to try, see e.g. https://test.lobid.org/gnd/10141738-X.

acka47 commented 1 year ago

This is fine for me. @LibrErli would you please take a look at the proposed changes?

LibrErli commented 1 year ago

To address your use case, how about we add direct support for copying to the clipboard when clicking the title (like the functionality on the URI clipboard icon)? I've deployed that to our test system for you to try, see e.g. https://test.lobid.org/gnd/10141738-X.

Thanks for all your replies. For my use case it is ok, but i am quite unsure if it is a very intuitive and the expected behaviour, to have h1-content copied to the clipboard if you click once at it. maybe a clipboard-icon on the end of the line could cover the functionality and make it much more clearer for all users?

fsteeg commented 1 year ago

i am quite unsure if it is a very intuitive and the expected behaviour, to have h1-content copied to the clipboard if you click once at it. maybe a clipboard-icon on the end of the line could cover the functionality and make it much more clearer for all users?

I tried it with an icon, but I did not find a good way to combine / align the icon with the header and labels.

But you do get the popup when hovering over the header, right? I think that does make it clear.

LibrErli commented 1 year ago

i am quite unsure if it is a very intuitive and the expected behaviour, to have h1-content copied to the clipboard if you click once at it. maybe a clipboard-icon on the end of the line could cover the functionality and make it much more clearer for all users?

I tried it with an icon, but I did not find a good way to combine / align the icon with the header and labels.

But you do get the popup when hovering over the header, right? I think that does make it clear.

for my use case your adaption works pretty well. hopefully it won't confuse other users too much. let's give it a try! thank you very much for your effort!