hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
25 stars 5 forks source link

Depiction is not taken from EntityFacts #332

Closed acka47 closed 1 year ago

acka47 commented 1 year ago

Reported by E.S. via email on 2022-12-05 See https://lobid.org/gnd/120965100 where no image is shown and also the JSON contains no depiction information. In EntityFacts it is available, though:

{
   "depiction":{
      "@id":"https://commons.wikimedia.org/wiki/Special:FilePath/Eva%20strautmann.JPG",
      "publisher":"Wikimedia Commons",
      "copyrighted":"true",
      "creator":[
         "Uwe Buchhop"
      ],
      "creditText":[
         "Uwe Buchhop via Eva Strautmann"
      ],
      "license":[
         {
            "@id":"https://creativecommons.org/licenses/by/3.0/de/deed.en",
            "abbr":"CC BY 3.0 de",
            "name":"Creative Commons Attribution 3.0 de",
            "attributionRequired":"true",
            "restrictions":""
         }
      ],
      "url":"https://commons.wikimedia.org/wiki/File:Eva%20strautmann.JPG?uselang=en",
      "thumbnail":{
         "@id":"https://commons.wikimedia.org/wiki/Special:FilePath/Eva%20strautmann.JPG?width=270"
      }
   }
}

I am not sure what the underlying problem is. Did the addition of attribution information for images iN EntityFacts maybe break something?

fsteeg commented 1 year ago

Enrichment from EntityFacts was broken due to faulty index config, I just noticed that while looking into the uncompacted fields issue. I thought that would be only for updates, but this here seems to indicate it's a general issue. Will look into that, might require full baseline conversion and reindex.

fsteeg commented 1 year ago

Deployed to production: https://lobid.org/gnd/120965100

(It wasn't just a config issue, the new entityfacts index seems to be broken: https://github.com/hbz/lobid-gnd/issues/334)

acka47 commented 1 year ago

+1 Closing