hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
26 stars 5 forks source link

Fix `@context` for `usingInstructions`& `professionOrOccupation` #360

Closed acka47 closed 1 year ago

acka47 commented 1 year ago

Should finally resolve (partially) #333 . Might resolve (partially) https://github.com/hbz/lobid/issues/419 .

fsteeg commented 1 year ago

Deployed, will be used for tonight's updates. What about the professionOrOccupation errors?

acka47 commented 1 year ago

What about the professionOrOccupation errors?

These might be fixed with https://github.com/hbz/lobid-gnd/pull/360/commits/1f10a4e4ddac0cc0ea812f98e5a2cf3caf3e6da8 . The respective issue is https://github.com/hbz/lobid/issues/419 (we should have moved that to the lobid-gnd repo, I always have trouble finding it).

fsteeg commented 1 year ago

Also deployed https://github.com/hbz/lobid-gnd/commit/1f10a4e4ddac0cc0ea812f98e5a2cf3caf3e6da8 for tonight's updates.

fsteeg commented 1 year ago

Pushed https://github.com/hbz/lobid-gnd/pull/360/commits/a06af85075fce419a47285c915c5e717b4721564, looks good for the tests. Deployed to the servers for nightly updates. We will still get the alert since the current test index will remain broken, but we should be able to check the updates. I've also triggered creating a new baseline index for testing, so we should be able to get an up-to-date index next week.

acka47 commented 1 year ago

professionOrOccupation looks better now. In those records changed on Friday, the order looks good as well: https://test.lobid.org/gnd/search?q=describedBy.dateModified%3A2023-11-03+AND+_exists_%3AprofessionOrOccupation&format=json (Example: http://test.lobid.org/gnd/1308554133)

However, it does not look good for others but I guess, the changes only apply to the latest modifications, don't they?

Re. usageInstructions we had already seen that it works, hadn't weß? (But I can not find an example on test now to verify.)

fsteeg commented 1 year ago

However, it does not look good for others but I guess, the changes only apply to the latest modifications, don't they?

Yes, we will have to re-index updates into a clean index. I will test with the new test index I created, and if that works I will re-index the missing updates into the current production index.

fsteeg commented 1 year ago

Deployed updates to (new) test setup, no uncompacted fields, looks good:

acka47 commented 1 year ago

+1

fsteeg commented 1 year ago

Deployed to production, corresponding to the test links above:

Will merge, but will remove the closing references before (https://github.com/hbz/lobid-gnd/issues/333, https://github.com/hbz/lobid/issues/419) since these will only be resolved after a new baseline.