hbz / lobid-gnd

UI and API to the Integrated Authority File (Gemeinsame Normdatei, GND)
http://lobid.org/gnd
Eclipse Public License 2.0
25 stars 5 forks source link

Set up reconciliation service for subdomain usage #407

Closed fsteeg closed 2 months ago

fsteeg commented 2 months ago

Basic idea: we replace the internal @routes.Reconcile.reconcile() route (/gnd/reconcile/) with the host name from conf/application.conf (set to https://reconcile.lobid.org for testing). The web server proxies / to /gnd/reconcile/ (as well as /gnd/ -> /gnd/ for assets and view / preview links).

dr0i commented 2 months ago

I think I don't like that https://reconcile.lobid.org/ points to lobid.org/gnd while we also have other lobid-services (resources; organisations ...). But that is decided as it is already officially documented at https://reconcile.lobid.org/ ?

fsteeg commented 2 months ago

No, https://reconcile.lobid.org/ is just for testing. It's the value configured in application.conf on the test system, that's why it appears on the page. I agree it's confusing and should be renamed e.g. to https://reconcile-gnd-test.lobid.org/ (in the GitLab issue though, where reconcile.lobid.org came up).