search

hbz / lobid-organisations

Transformation, web frontend, and API for lobid-organisations
http://lobid.org/organisations
Eclipse Public License 2.0
13 stars 3 forks source link

Update DNB OAI URL to HTTPS #448

Closed acka47 closed 2 years ago

acka47 commented 2 years ago

see https://github.com/hbz/lobid-gnd/issues/317#issuecomment-1198081452 for background

lobid-organisations also uses our DNB OAI proxy:

https://github.com/hbz/lobid-organisations/blob/26423ac148a631e691daf65201638ef794f9b4dd/conf/application.conf#L22)

So the production process should also be fixed with https://github.com/hbz/lobid-gnd/issues/317

dr0i commented 2 years ago

I think this is not really helpful, as this URL is forbidden - with or without TLS. This PR doesn't fix something.

Doing sbt update test , nothing seems to be really tested - it just compiles successfully. Maybe I am wrong here. But that would make sense, because a test with the "forbidden" URL should fail.

dr0i commented 2 years ago

This PR references https://github.com/hbz/lobid-gnd/issues/317 for there will be missing data here as for gnd. As the data is completley rebuild at the 5th of every month I will just leave it as it is to let it heal itself. Would be good to have some provenience data like dateModified to check this but these data seem to be not part of lobid-organisations.

dr0i commented 2 years ago

Can be closed I think.