search

hbz / lobid-organisations

Transformation, web frontend, and API for lobid-organisations
http://lobid.org/organisations
Eclipse Public License 2.0
13 stars 3 forks source link

128 provenance info #463

Closed TobiasNx closed 1 year ago

TobiasNx commented 1 year ago

The indexing breaks because of the last commit. I am not sure why. I add two elements to mainEntityOfPage. It could be that used is a weird array. Could you have a look. see #128

fsteeg commented 1 year ago

Didn't look closely yet, but there are a lot of failing tests. Also there are conflicts, so maybe something went wrong when branching off or something, and this is not actually the correct state? I'd suggest resolving the conflicts first and then we can take a closer look at the failures.

TobiasNx commented 1 year ago

I merged the master into this. The error still there. I assume that the old version of elasticSearch is not able to work with this mixed array:

"used": [
        {
            "id": "http://services.dnb.de/sru/bib?operation=searchRetrieve&query=isl%3DDE-294&recordSchema=PicaPlus-xml&version=1.1",
            "sourceOrganisation": {
                "id": "https://sigel.staatsbibliothek-berlin.de/vergabe/isil/",
                "label": "Deutsche ISIL-Agentur und Sigelstelle an der Staatsbibliothek zu Berlin"
                }
        },
        "https://github.com/metafacture/metafacture-core",
        "https://github.com/hbz/lobid-organisations/blob/master/conf/fix-sigel.fix",
        "https://github.com/hbz/lobid-organisations/blob/master/conf/fix-enriched.fix"
    ]
TobiasNx commented 1 year ago

ElasticSearch-Docu says: Arrays with a mixture of data types are not supported: [ 10, "some string" ]

That could be the problem, but I dont know why this is possible in ElasticSearch with OERSI: See @context here

TobiasNx commented 1 year ago

@dr0i can you help?

acka47 commented 1 year ago

I dont know why this is possible in ElasticSearch with OERSI: See @context here

I think this is due to the fact that @context is not indexed.

TobiasNx commented 1 year ago

@acka47 and I decided to kick out the metafacture links to only use the sourceData as object for now.

TobiasNx commented 1 year ago

like this:


"used": [
        {
            "id": "http://services.dnb.de/sru/bib?operation=searchRetrieve&query=isl%3DDE-294&recordSchema=PicaPlus-xml&version=1.1",
            "sourceOrganisation": {
                "id": "https://sigel.staatsbibliothek-berlin.de/vergabe/isil/",
                "label": "Deutsche ISIL-Agentur und Sigelstelle an der Staatsbibliothek zu Berlin"
                }
    ]