search

hbz / lobid-organisations

Transformation, web frontend, and API for lobid-organisations
http://lobid.org/organisations
Eclipse Public License 2.0
13 stars 3 forks source link

Add geo coordinates to DBS-derived entries #49

Closed acka47 closed 8 years ago

acka47 commented 9 years ago

Currently, we only have geo coordinates for organizations from the Sigelverzeichnis. We also have to geocode the ones solely derived from DBS data, e.g. http://beta.lobid.org/organisations/DBS-GF429#!.

philboeselager commented 9 years ago

@dr0i : you mean https://github.com/hbz/oerworldmap.prototype/blob/7a7d30ffb1dc36368e0067652742b3adb9743086/oer-data/src/main/java/org/hbz/oerworldmap/Transform.java --> geoWithHttpLookup() as a starting point?

dr0i commented 9 years ago

Yes.It's is a nicer way (more metafacture like) than https://github.com/lobid/lodmill/blob/master/lodmill-rd/src/main/java/org/lobid/lodmill/PipeLobidOrganisationEnrichment.java. The latter gives you the heuristics used by the old lobid organisations for getting geo data. If you are also going to use OSM, look at their API now, they may have changed/improved things.

philboeselager commented 9 years ago

ES Index on q.....1, Index: "organisations-20151111-pvb"

acka47 commented 9 years ago

@philboeselager Could you put this and the other changes on http://beta.test.lobid.org/organisations? This would make it easier for me to review...

fsteeg commented 9 years ago

@acka47 @philboeselager That should be http://test.lobid.org/organisations (not sure why your beta.test link even works), see details at https://github.com/hbz/lobid-organisations/issues/71.

philboeselager commented 9 years ago

@fsteeg Thanks - I knew what acka meant ;-) @acka47 new index is connected to http://test.lobid.org/organisations/

acka47 commented 9 years ago

Can you say something about the number of organizations where the geo lookup worked? From the entries of this list of 199 DBS-derived entries 146 have geo information. From this list only 54.

Do you do the lookup on the data with posta code in streetAddress (see https://github.com/hbz/lobid-organisations/issues/50#issuecomment-156358151)? This could be a reason for the relatively low number of hits...

philboeselager commented 8 years ago

83 has been merged. Deployed to beta.lobid.org . Closing.