Fix name for dbsId in wikidata lookups #383

hbz / lobid-organisations

Transformation, web frontend, and API for lobid-organisations

http://lobid.org/organisations

Eclipse Public License 2.0

13 stars 3 forks source link

Fix name for dbsId in wikidata lookups #383 #499

Closed TobiasNx closed 1 year ago

TobiasNx commented 1 year ago

Due to inconsistent naming the lookup failed. This commit fixes the lookup. Related to #383

dr0i commented 1 year ago

I don't know if this fixes the problem. We cannot rebuild an index atm because we try to lookup a file (isil2wikidata) that was removed in aa7ec766a02f0e06783ad101d44c3cdc8c4e1688.

TobiasNx commented 1 year ago

You added this file via cron job: https://github.com/hbz/lobid-organisations/pull/498 and can create it with the bash script that you mentioned in the README.md

Also test/transformation/output/enriched-test.json-dbs shows already the wanted outcome.

To improve the testing of new features and bug fixes, #460 would help since the elastic search bulk is not very helpful to highlight the changes.

dr0i commented 1 year ago

Right ! I forgot already about the script creating the needed data. So atm. , first time it's rolled out, one has to execute the script (like mentioned in the README). Otherwise a deployment is not possible.