hbz / lobid-resources

Transformation, web frontend, and API for the hbz catalog as LOD
http://lobid.org/resources
Eclipse Public License 2.0
7 stars 7 forks source link

Add editorconfig-maven-plugin #1997

Closed TobiasNx closed 4 months ago

TobiasNx commented 4 months ago

Discussed with @dr0i to add check for editorconfig with https://github.com/ec4j/editorconfig-maven-plugin

I added the plugin with 1. commit to the pom.xml and 2. commit reformatted all files except the test xml and json files with mvn editorconfig:format

This does not seem to test automatically, perhaps that has to be configured. For now one has to run mvn editorconfig:check

Can you do this @dr0i

dr0i commented 4 months ago

Have a look at 47ba540 , there the build already fails.

I've added the mvn editorconfig:check to GitHub action - this is what is done e.g. in metafacture.

TobiasNx commented 4 months ago

Don't apply formatting to binary data. This may break things unexpectedly.

not sure how to do this. @dr0i can you help.

dr0i commented 4 months ago

Replaced by #2007. Closing.