search

hbz / lobid-resources

Transformation, web frontend, and API for the hbz catalog as LOD
http://lobid.org/resources
Eclipse Public License 2.0
9 stars 7 forks source link

EditorConfig did not catch wrong indentation in java classes? #2023

Open TobiasNx opened 6 months ago

TobiasNx commented 6 months ago

Not sure why, but I saw, that there are still lots of tabs in the Java Classes although we decided to use spaces and use an editorconfig plugin to help with that: https://github.com/hbz/lobid-resources/pull/2007

https://github.com/hbz/lobid-resources/blob/eb223f801a5fb7f3e2b84b2bc2f079b6ea9e87f2/web/test/tests/IndexIntegrationTest.java#L162-L163

here spaces and tabs side by side. the rest are spaces.

Shouldnt the editorconfig help u with that? Or should the checkstyles alarm us about that?

TobiasNx commented 6 months ago

okay, this is due to the missing java linter. hmm. https://stackoverflow.com/questions/75801441/how-to-format-java-code-based-on-editorconfig-file

TobiasNx commented 6 months ago

Is there another way to check this?

blackwinter commented 6 months ago

See metafacture/metafacture-fix#179.