hbz / lobid

Linking Open Bibliographic Data
https://lobid.org/
Eclipse Public License 2.0
16 stars 4 forks source link

Redundant preferredNames as array #153

Closed acka47 closed 9 years ago

acka47 commented 9 years ago

Examples in this result list: http://lobid.org/nwbib/search?person=Konrad+Adenauer&from=20&sort=

E.g. http://lobid.org/resource/HT015891797/about & http://lobid.org/resource/HT014319164/about

Note :exclamation: This problem occurs when a person is both contributor and subject.

acka47 commented 9 years ago

Another example: http://lobid.org/nwbib/HT018567032

dr0i commented 9 years ago

Test-set deployed to staging.

acka47 commented 9 years ago

Looks good. Please leave out one white space before the comma. Example snippet:

"preferredName" : "Adenauer, Konrad , 1876-1967",
"preferredNameForThePerson" : "Adenauer, Konrad , 1876-1967"
acka47 commented 9 years ago

In the other example, not only there also is the white space before the comma but also the name array with the preferedNameForThePerson property:

"preferredName" : "Reinarz, Titus , 1948-",
"preferredNameForThePerson" : [ "Reinarz, Titus", "Reinarz, Titus , 1948-" ]
dr0i commented 9 years ago

Re: preferedNameForThePerson I just treated preferedName as this is the property which is shown , both in lobid RDFa and NWBib.

acka47 commented 9 years ago

I just treated preferedName as this is the property which is shown , both in lobid RDFa and NWBib.

You did? It is quite strange that in http://test.lobid.org/resource/HT015891797/about both preferedName and preferedNameForThePerson are ok.

dr0i commented 9 years ago

Not strange - in HT015891797 preferedNameForThePerson was not an array in the first place (look at http://lobid.org/resource/HT015891797/about ). Anyway, I'll have a look at it now

dr0i commented 9 years ago

TODO: get rid of preferredNamesForThePersonproperty in subjects, see http://test.lobid.org/resource/HT018312899/about ("Grabbe, Christian Dietrich: Der Cid").

dr0i commented 9 years ago

Test-set deployed to staging.

acka47 commented 9 years ago

+1

dr0i commented 9 years ago

Merged into master . Needs a complete reindexing to be deployed to production, though.

dr0i commented 9 years ago

Deployed to production (mind that the first two examples in this issue are still cached with the old values. Wait one hour.)