search

hbz / lobid

Linking Open Bibliographic Data
https://lobid.org/
Eclipse Public License 2.0
16 stars 4 forks source link

Support combination of different query parameters #19

Closed fsteeg closed 10 years ago

fsteeg commented 10 years ago

See https://github.com/lobid/lodmill/issues/356

Deployed to staging: http://test.lobid.org/api

Sample queries:

http://test.lobid.org/resource?name=Typee&author=118580604 http://test.lobid.org/resource?name=Fahrrad&subject=4031483-2 http://test.lobid.org/resource?author=Abramson&id=9780899502847

acka47 commented 10 years ago

The examples look good. I would like to know with which fields this does work?

At first, I thought it would also work with any other field, e.g. placeOfPublication but http://test.lobid.org/resource?subject=4000626-8&placeOfPublication=K%C3%B6ln also gives a results with placeOfPublication "Escchborn". `publisher doesn't seem to be supported as well, e.g. http://test.lobid.org/resource?name=Semantik&publisher=Fink.

Can I ask for am specific language? If yes, how? http://test.lobid.org/resource?name=Semantik&language="http://id.loc.gov/vocabulary/iso639-2/deu" doesn't work. It would be great if the short language codes would be supported, e.g. http://test.lobid.org/resource?name=Semantik&language=deu

If this is just some kind of proof of concept for a few fields, I give my +1. If it is supposed to work with any fields, there still is some work to be done.

fsteeg commented 10 years ago

@acka47 This just adds support to combine existing query parameters, it doesn't add new parameters like the language, publisher, or placeOfPublication parameters you mentioned.

@dr0i Reassigning to you for code review.