search

hbz / lobid

Linking Open Bibliographic Data
https://lobid.org/
Eclipse Public License 2.0
16 stars 4 forks source link

Support multiple comma separated values with OR for `type=` param #22

Closed fsteeg closed 10 years ago

fsteeg commented 10 years ago

See https://github.com/lobid/lodmill/issues/508

Deployed to staging, see: http://test.lobid.org/subject?name=Heinsberg&type=http://d-nb.info/standards/elementset/gnd%23BuildingOrMemorial,http://d-nb.info/standards/elementset/gnd%23PlaceOrGeographicName&format=full

acka47 commented 10 years ago

+1 Works, though the query you provide doesn't actually test whether itis actually implemented. (Every gnd:BuildingOrMemorial is by definition also a gnd:PlaceOrGeographicName.) This is better: http://test.lobid.org/subject?name=Heinsberg&type=http://d-nb.info/standards/elementset/gnd%23Person,http://d-nb.info/standards/elementset/gnd%23PlaceOrGeographicName

fsteeg commented 10 years ago

But not every placeOrGeographicName is also a buildingOrMemorial.

Compare this to the query I provided: http://test.lobid.org/subject?name=Heinsberg&type=http://d-nb.info/standards/elementset/gnd%23BuildingOrMemorial&format=full

Still not an ideal test case, that is true.