search

hbz / lobid

Linking Open Bibliographic Data
https://lobid.org/
Eclipse Public License 2.0
16 stars 4 forks source link

Support multi value queries #226

Closed fsteeg closed 9 years ago

fsteeg commented 9 years ago

For https://github.com/hbz/nwbib/issues/97 and https://github.com/hbz/nwbib/issues/129 we need to support multi-value queries (logical AND) for:

We already support multi-value queries (logical OR) for:

fsteeg commented 9 years ago

Deployed to staging, see:

acka47 commented 9 years ago

Subject search also works with subject URIs, e.g. http://test.lobid.org/resource?subject=http%3A%2F%2Fd-nb.info%2Fgnd%2F4066438-7,http%3A%2F%2Fd-nb.info%2Fgnd%2F4077548-3&format=full

acka47 commented 9 years ago

...as well as http://test.lobid.org/resource?subject=http://d-nb.info/gnd/4066438-7,http://d-nb.info/gnd/4077548-3&format=full

acka47 commented 9 years ago

I assume the spatial search also works with URIs. Can't test it as there are probably not so much resources with double NWBib spatial notations and probably none of them in the test set.

acka47 commented 9 years ago

I don't see the use of combining two medium types with AND. With the exception of "electronic resource" and "oline resource" there should be only one medium. IMO, an OR combination would make more sense in this case.

acka47 commented 9 years ago

Will leave this open, as discussed offline. We are still not sure whether an AND combination for multi-value queries is the way to go. The optimal way would be to support AND and OR API-wise. This might best be implemented with API 2.0, though...

For now, @fsteeg will get to know the frontend possibilities and we will discuss this again at a later point.

fsteeg commented 9 years ago

After some more discussion we agreed to use OR, mainly for being consistent across all facets (holdings only make sense with OR) and our current UX (facets do not narrow down themselves).

fsteeg commented 9 years ago

Changed boolean logic to OR, deployed to staging, see:

acka47 commented 9 years ago

+1

fsteeg commented 9 years ago

Deployed to production, closing. See: