search

hbz / lobid

Linking Open Bibliographic Data
https://lobid.org/
Eclipse Public License 2.0
15 stars 4 forks source link

Add /team page with contact information & foaf profiles #325

Closed acka47 closed 7 years ago

acka47 commented 7 years ago

We decided to link to the /team page in the "information" (i) tab and display general contact information (a reworked version of http://lobid.org/contact) there as well as a list of team members linking to each team member's profile page.

The profile pages will be reworked versions of the existing ones, e.g. http://lobid.org/team/fs. We will use http://lobid.org/team/{initials}#! as the person ID and http://lobid.org/team/{initials} as the page URL (meaning what once was the page URL will be the person URL but hey...). Profiles will be put as .jsonld files into https://github.com/hbz/lobid/tree/master/conf.

acka47 commented 7 years ago

Of course, we should redirect http://lobid.org/contact to http://lobid.org/team when this is done.

fsteeg commented 7 years ago

Rebased 325-team branch with my changes on 325-AddTeamInfo, deleted 325-AddTeamInfo.

fsteeg commented 7 years ago

Current profile pages on staging:

http://stage.lobid.org/team/ap http://stage.lobid.org/team/pc http://stage.lobid.org/team/fs

@dr0i: I used your avatar picture as image because the other one was so small, you can push a change to the 325-team branch if you want to change it.

@ChristophEwertowski: You'll need a file called ce.json with content like https://github.com/hbz/lobid/blob/325-team/conf/team/ap.json, you can push it to the 325-team branch.

Next up for myself: set up the actual team page with links to these profiles.

acka47 commented 7 years ago

Looks good. I think we should talk on Thursday next week about which additional information to add and show in the HTML

dr0i commented 7 years ago

+1

fsteeg commented 7 years ago

Deployed Christoph's profile to: http://stage.lobid.org/team/ce

@acka47 @ChristophEwertowski: please include a link or # with issue number (e.g. #325) in your commit messages to make them show up here in the issue. This makes it much easier to see what's happening, as it collects all related commits in one place.

@acka47: beside the question of what to show in the HTML, we might also want to discuss what to add to the data, e.g. for this context here jobTitle might make sense. Also something to replace the old publications field (maybe more general?). But perhaps all of that is a topic for a separate issue, after we have set up the general team and profile pages, instead of delaying that for at least one week.

acka47 commented 7 years ago

beside the question of what to show in the HTML, we might also want to discuss what to add to the data, e.g. for this context here jobTitle might make sense. Also something to replace the old publications field (maybe more general?).

Yes, that is what I meant with "which additional information to add".

But perhaps all of that is a topic for a separate issue, after we have set up the general team and profile pages, instead of delaying that for at least one week.

+1

One last thing: I don't know whether we need the "works for" content shown in the HTML. If yes, we should add it as an object with label and show the label with an underlying link.

fsteeg commented 7 years ago

Deployed team page to: http://stage.lobid.org/team, with redirect from: http://stage.lobid.org/contact.

The page is not localized for German yet, I will add translation after +1 for the English content.

acka47 commented 7 years ago

I am not sure about the layout, it is all looking very dense. It is probably best to talk this through on Friday, especially as I don't have any more time today..

Some raw ideas:

fsteeg commented 7 years ago

Re latest changes @acka47: I think roleName should be something like "Software developer", not "Software development", see https://schema.org/roleName

And since what I'm talking about is completely invisible when looking at this issue, let me quote myself:

@acka47: please include a link or # with issue number (e.g. #325) in your commit messages to make them show up here in the issue. This makes it much easier to see what's happening, as it collects all related commits in one place.

fsteeg commented 7 years ago

Deployed new version, using the JSON data for the team:

http://stage.lobid.org/team

Note that since the member links are taken from the file, they point to the production version.

fsteeg commented 7 years ago

Redeployed after offline dscussion with @acka47: http://stage.lobid.org/team

acka47 commented 7 years ago

I like this much better but we have to unify the style of the icons:

fsteeg commented 7 years ago

Redeployed with updated icons: http://stage.lobid.org/team

acka47 commented 7 years ago

Looks much better now. +1