hbz / lobid

Linking Open Bibliographic Data
https://lobid.org/
Eclipse Public License 2.0
15 stars 4 forks source link

Restore English team page #395

Closed fsteeg closed 4 years ago

fsteeg commented 5 years ago

I think we lost the English team page when we removed the lobid 1.x web app (https://github.com/hbz/lobid/commit/72f105c2007b63eca1101e2c293fade45a4056d8). The JSON file with the English labels is still there. Maybe we should move the template that generated the page from the JSON file into another app?

dr0i commented 4 years ago

We could render the language variant pages using https://lobid.org/team.json. As discussed with @acka47 we could use the gatsby static side generator. As it uses graphql we could reuse gatsby to generate pages querying our slides, blogs etc.

I managed to install gatsby. , grep in vhosts to see where to reach it via the Browser. The installation location is the common underlobid@emphytos.

dr0i commented 4 years ago

Build with gatsby, see http://stage.lobid.org/.

fsteeg commented 4 years ago

Main page looks good, but on the team page (http://stage.lobid.org/team_en/) the German/English switch and some CSS are missing (see ì menu compared to http://stage.lobid.org). It would also be nice if they followed the same naming convention (e.g. team-de, like index-de, not team_de).

dr0i commented 4 years ago

Gatsby now uses the react-bootstrap and no more jquery but react-native components in the navbar. I got it look nearly the same as the old navbar, but it's not exactly the same. See http://stage.lobid.org/ and don't forget to clean your browser's cache.

dr0i commented 4 years ago

Regarding naming/structuring of language specific sites: please have a look at the different proposals and tell me your favourite. We may discuss this also offline.

dr0i commented 4 years ago

Decided offline to go with the language suffix for pages and to get rid of the "html" suffix. @acka47 @fsteeg please review http://stage.lobid.org/ note to self: when deploying don't forget to route index in apache conf to the index pages without the html suffix.

fsteeg commented 4 years ago

@acka47 @fsteeg please review http://stage.lobid.org/

Great, looks good! +1

acka47 commented 4 years ago

+1

dr0i commented 4 years ago

Deployed to production, closed.