search

hbz / lobid

Linking Open Bibliographic Data
https://lobid.org/
Eclipse Public License 2.0
15 stars 4 forks source link

Use working image URL in Adrian's profile #403

Closed acka47 closed 4 years ago

acka47 commented 4 years ago

I updated the URL in the JSON. Should I also have updated it in the HTML? I guess it will be generated automatically so I left it.

https://github.com/hbz/lobid/blob/c888a5be5e3af84b8457b141c61242128bba3b7d/team/ap#L100

fsteeg commented 4 years ago

As discussed offline, you need to update the HTML as well, since after the removal of the old Play app, these are just static files.

acka47 commented 4 years ago

I had to update it in three places: JSON file, HTML image link, embedded JSON-LD in HTML. This is not convenient at all...

fsteeg commented 4 years ago

I had to update it in three places: JSON file, HTML image link, embedded JSON-LD in HTML. This is not convenient at all...

Yup, it isn't. I am even more bothered about the lack of an English version. Maybe we should switch back to a web app here instead of static sites? Or some static site generator like Gatsby?

acka47 commented 4 years ago

What is it with the pending check?

fsteeg commented 4 years ago

What is it with the pending check?

Weird, no idea. I've disabled the Travis webhook for this repo. Maybe that's something really old?

@dr0i Could you deploy this? I'm not sure how/where to deploy (these are static sites in Apache now, correct?)

dr0i commented 4 years ago

If you also like, as I assume, to use the new picture also in the team's page , I will change the index.html not only at the server but also in git. Just hit me.

dr0i commented 4 years ago

@fsteeg correct, this repo is checked out at emphytos:/srv/www/htdocs/lobid.org/ .

dr0i commented 4 years ago

@acka47 I updated also the branch. Please have a look.

dr0i commented 4 years ago

Merged and deployed. Closed.