hbz / nwbib

Die Nordrhein-Westfälische Bibliographie
http://nwbib.de
3 stars 2 forks source link

Some tests are failing; tests use live API #633

Closed dr0i closed 1 year ago

dr0i commented 1 year ago

Working on https://github.com/hbz/lobid-resources/issues/1846. Doing sbt test I got in master:

[error] Failed: Total 965, Failed 4, Errors 0, Passed 953, Skipped 8
[error] Failed tests:
[error]         tests.ExternalIntegrationTest
[error]         tests.AllTests

Tests seem to rely on live API and broad queries (so data can change unexpectedly)? If these tests are ignored in github-actions, should we not remove them? Or, asked differently: what is their purpose ?