search

hbz / oerworldmap-ui

The user interface for https://oerworldmap.org/
Apache License 2.0
4 stars 8 forks source link

Updates 'Call for tender' value #633

Closed jurecuhalev closed 4 years ago

jurecuhalev commented 4 years ago

This PR updates "Call for tender" to be "Call for tender/proposal". It's rebased from https://github.com/hbz/oerworldmap-ui/pull/629 .

To deploy, from oerworldmap-ui (please change http://localhost:9000 to correct API location)

curl -H "Content-type: application/json" http://localhost:9000/import/ -d @src/json/policyTypes.json

Ref: https://github.com/hbz/oerworldmap/issues/1937

literarymachine commented 4 years ago

@dr0i please deploy to beta.

dr0i commented 4 years ago

Deployed to beta.

jurecuhalev commented 4 years ago

I wonder if deploy/ingestion didn't work correctly, as frontend still shows wrong tender label, but in edit it's correct: https://beta.oerworldmap.org/resource/urn:uuid:b3ecd503-2823-4d59-b2b9-f778f6bcbbef

literarymachine commented 4 years ago

I wonder if deploy/ingestion didn't work correctly

Yes, @dr0i did you run the cURL command from https://github.com/hbz/oerworldmap-ui/pull/633#issue-473181746?

acka47 commented 4 years ago

@literarymachine @gandalfar Just to let you know, @dr0i had to take some days off this week and hasn't been working since Tuesday. He probably will be back on Monday.

dr0i commented 4 years ago

Yes, indeed I forgot to import the policy type (http://localhost:9000 is the right place - opened a new PR to make the port of the play API more overt), restarted everything, but cannot see the the label updated in the German version when clicking in https://beta.oerworldmap.org/resource/urn:uuid:b3ecd503-2823-4d59-b2b9-f778f6bcbbef at "Also available in: German" - only the title is changed to German, the rest (as for the label of the policy type) sticks to English. However, if I switch to German using the icon at the top bar to switch to German everything is switched correctly. Shall I open a new issue for this?

literarymachine commented 4 years ago

"Also available in: German" - only the title is changed to German, the rest (as for the label of the policy type) sticks to English. However, if I switch to German using the icon at the top bar to switch to German everything is switched correctly. Shall I open a new issue for this?

Also available in only refers to the data entered by users. This is expected behavior, no need for an issue!

jurecuhalev commented 4 years ago

It's working correctly now. Thanks.

@dr0i please deploy to production

dr0i commented 4 years ago

Deployed to production, closed.