search

hbz / oerworldmap-ui

The user interface for https://oerworldmap.org/
Apache License 2.0
4 stars 8 forks source link

Add reference number field #634

Closed literarymachine closed 4 years ago

literarymachine commented 4 years ago

This complements https://github.com/hbz/oerworldmap/pull/1942, see hbz/oerworldmap#1938

literarymachine commented 4 years ago

@dr0i please deploy to beta.

dr0i commented 4 years ago

Deployed to beta.

jurecuhalev commented 4 years ago

@dr0i I don't see these changes on beta. Is this because of failed compilation step described in https://github.com/hbz/oerworldmap-ui/issues/640 ?

literarymachine commented 4 years ago

This is because the changes in the UI are rather cosmetic (labels etc), the actual change in the data model happens in https://github.com/hbz/oerworldmap/pull/1942. Sorry, forgot to assign @dr0i!

dr0i commented 4 years ago

As deployed https://github.com/hbz/oerworldmap/pull/1942 to beta, please have a look again at this @gandalfar .

jurecuhalev commented 4 years ago

I've checked and it's still not showing up. I've rechecked on a local dev and it's showing up correctly.

@literarymachine does this need any index/db to be rebuilt?

literarymachine commented 4 years ago

The schema changes from https://github.com/hbz/oerworldmap/pull/1942 are not reflected in https://beta.oerworldmap.org/assets/json/schema.json. @dr0i did you restart the API after merging?

dr0i commented 4 years ago

@literarymachine yeah I did restart the API , but didn't 'sbt stage' before. This just restarts the old code. I will open a PR to document it properly, since the README tells to sbt run but that's not cleaning and rebuilding the target.

jurecuhalev commented 4 years ago

This is now working correctly on beta. Please deploy to production @dr0i .

dr0i commented 4 years ago

Deployed to production, closed.