Closed acka47 closed 7 years ago
On beta this issue is is still remaining using the new mapping layer. (Issue #659 is solved on beta: Both exclaves are shown coloured like the connected country.)
Current status on beta is not really a fix for this, see https://github.com/hbz/oerworldmap/issues/659#issuecomment-238217270 and #810.
Kosovo is missing in our countries lists. Not sure, whether this is part of the solution but it might be of some interest: add to countries.properties:
XK=Kosovo
Add to all.json:
{"name":"Kosovo","alpha-2":"XK","alpha-3":"XKX","iso_3166-2":"ISO 3166-2:RS-KM"}
I did not find information about
The world bank assigns "KSV" as "country id" for Kosovo. Their "country id" is the same as ISO_3166-1_alpha-3 for other countries. So we could assign "KSV" to Kosovo without putting our heads above the parapet.
Ok, I took a look and in our country vector data from natural earth, Kosovo has an id of "-99". Actually it should be painted white anyway, as this is the default and actually returned by the styling callback. Somehow I'll find the reason for it being transparent.
So is it fixed, we take KSV? Or the informal two-letter-code "XK"? See: https://github.com/nvkelso/natural-earth-vector/issues/134
As long as we have no further information, I would go for:
{"name":"Kosovo","alpha-2":"XK","alpha-3":"KSV","iso_3166-2":"ISO 3166-2:RS-KM"}
For documentation (of https://github.com/hbz/oerworldmap/commit/14d82f44e0c2aa144f1ea88d3d80769a302e4e95 and https://github.com/hbz/oerworldmap/commit/37de5f7e1439ed0031dee12d2a74b74b890db9a3):
id
of "-99".id
"XK" and the others "X1" ... "X4", to have them unique at least.i18n.countries
... @literarymachine any idea?Hijax.behaviours.map.debugShowCountry('XK')
in the console.As it's not clear if we will work with the same country boundaries in case of switching the mapping library, I'd suggest to skip research about the other regions, until then.
Reported by K.D: The Kosovo is covered by water in OER World Map and can not be clicked. Screenshot: